fix: panic when using pointer to map as env #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, passing a pointer to a map (e.g. `*map[string]any`) to `expr.Env()` would cause a panic because reflection methods were called on the pointer value instead of the underlying map. With this change the value is first deref'd in the config before any map operations are performed. Consequently, the `vm.Run()` method needs to dereference the env map. This ensures compatibility with the optimisations like `OpLoadFast` where the compiler determines the environment simply as `map[string]any`. Regression test added. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Member
|
But why would |
antonmedv
reviewed
Dec 8, 2025
|
|
||
| func (vm *VM) Run(program *Program, env any) (_ any, err error) { | ||
| if m, ok := env.(*map[string]any); ok && m != nil { | ||
| env = *m |
Member
There was a problem hiding this comment.
I think Expr sloud allow to types as incoming env: struct, *struct and map[string]...
Contributor
Author
I guess this would mostly be a quality of life improvement. Tried to think of an example. Maybe you unmarshal the Also @yawnBright feel free to chime in with your use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, passing a pointer to a map (e.g.
*map[string]any) toexpr.Env()would cause a panic because reflection methods were called on the pointer value instead of the underlying map. With this change the value is first deref'd in the config before any map operations are performed.Consequently, the
vm.Run()method needs to dereference the env map. This ensures compatibility with the optimisations likeOpLoadFastwhere the compiler determines the environment simply asmap[string]any.Regression test added.
Fixes #825.