Skip to content

Conversation

@danielcherubini
Copy link
Contributor

@danielcherubini danielcherubini commented Aug 21, 2017

I’ve refactored the require to create a promise array which will resolve vue files into JavaScript objects before the compile of the module.

This needs to handle the base url better.

nikos-fytros
nikos-fytros previously approved these changes Aug 21, 2017
@danielcherubini danielcherubini merged commit 6323430 into develop Aug 21, 2017
@danielcherubini danielcherubini deleted the feature/fix_regexes branch August 21, 2017 15:27
@codecov
Copy link

codecov bot commented Aug 21, 2017

Codecov Report

Merging #66 into develop will decrease coverage by 0.21%.
The diff coverage is 82.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
- Coverage    86.76%   86.54%   -0.22%     
===========================================
  Files           17       17              
  Lines          423      431       +8     
===========================================
+ Hits           367      373       +6     
- Misses          56       58       +2
Impacted Files Coverage Δ
src/utils/require.js 85.29% <82.85%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f76b7d...5753943. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants