fix issue with custom layout attributes being ignored #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #93 +/- ##
===========================================
+ Coverage 87.52% 88.24% +0.72%
===========================================
Files 17 17
Lines 449 451 +2
===========================================
+ Hits 393 398 +5
+ Misses 56 53 -3
Continue to review full report at Codecov.
|
Contributor
|
Holy shit... amazing. You wrote tests too!!! OMG ! |
danielcherubini
approved these changes
Oct 6, 2017
Contributor
|
This will go out in the next version today |
Contributor
Author
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
express-vue/express-vue#126 (comment)