Skip to content

Fix for windows paths #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix for windows paths #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/renderer/renderer-webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,12 @@ class Renderer {
const clientFilename = "client.bundle.js";
let memoryParsed;
if (filePath.includes(".expressvue")) {
memoryParsed = path.parse(filePath.replace(".expressvue/", "").split(this.pagesPath)[1]);
memoryParsed = path.parse(filePath.replace(".expressvue" + path.sep, "").split(this.pagesPath)[1]);
} else {
memoryParsed = path.parse(filePath.split(this.pagesPath)[1]);
}
const memoryBase = path.join(`/${this.baseUrl}/expressvue/bundles`, memoryParsed.dir);

const memoryBase = path.join(path.sep === '/' ? '/' : 'C:\\', `${this.baseUrl}/expressvue/bundles`, memoryParsed.dir);
const memoryPath = path.join(memoryBase, memoryParsed.name);

return {
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ module.exports.appConfig = function appConfig(filePath, config) {
}

const app = `import Vue from "vue";
import App from "${filePath}";
import App from ${JSON.stringify(filePath)};

export function createApp(data) {
const mergedData = Object.assign(App.data ? App.data() : {}, data);
Expand Down