Request with "HEAD" method will error

[mingoing]

Errorl log =>

Error: write after end
  at ServerResponse.OutgoingMessage.write (_http_outgoing.js:409:15)
  at ServerResponse.res.write (/home/xxx/app/node_modules/compression/index.js:95:17)
  at ServerResponse.res.end (/home/xxx/app/node_modules/compression/index.js:112:14)
  at ServerResponse.send (/home/xxx/app/node_modules/express/lib/response.js:191:8)
  at fn (/home/dan/app/node_modules/express/lib/response.js:900:10)
  at Immediate._onImmediate (/home/xxx/app/node_modules/express-handlebars/lib/utils.js:34:13)

[dougwilson]

Hi! This module is a no-op on HEAD requests--we even have a test for this: https://github.com/expressjs/compression/blob/master/test/test.js#L22

Please let me know what version of this module you are using, what version of Node.js and a full reproducable test case (you can always edit our test file if you're not sure how to provide a test case).

[dougwilson]

From your stack trace, if you really did get a HEAD request, you may want to verify something in your code base did not lower-casereq.method value--it is only valid to be upper-case. The reason I say this is because your stack trace includes Express render -> send calls and those are operating as if it's not a HEAD request, just like this module is.

[mingoing]

I create a test repo https://github.com/wlsy/compressionTest.git
npm install & npm start &node testHEAD.js

[dougwilson]

I'm sorry, it doesn't reproduce for me:

Doug.wilson@IN5358 ~/test
$ git clone https://github.com/wlsy/compressionTest.git
Cloning into 'compressionTest'...
remote: Counting objects: 23, done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 23 (delta 1), reused 23 (delta 1)
Unpacking objects: 100% (23/23), done.
Checking connectivity... done

Doug.wilson@IN5358 ~/test
$ cd compressionTest/

Doug.wilson@IN5358 ~/test/compressionTest (master)
$ npm install
cookie-parser@1.3.3 node_modules\cookie-parser
├── cookie@0.1.2
└── cookie-signature@1.0.5

debug@2.0.0 node_modules\debug
└── ms@0.6.2

morgan@1.3.2 node_modules\morgan
├── basic-auth@1.0.0
├── depd@0.4.5
└── on-finished@2.1.0 (ee-first@1.0.5)

serve-favicon@2.1.7 node_modules\serve-favicon
├── ms@0.6.2
├── fresh@0.2.4
└── etag@1.5.1 (crc@3.2.1)

compression@1.2.1 node_modules\compression
├── bytes@1.0.0
├── on-headers@1.0.0
├── vary@1.0.0
├── debug@2.1.0 (ms@0.6.2)
├── compressible@2.0.1 (mime-db@1.2.0)
└── accepts@1.1.3 (negotiator@0.4.9, mime-types@2.0.3)

body-parser@1.8.4 node_modules\body-parser
├── media-typer@0.3.0
├── raw-body@1.3.0
├── bytes@1.0.0
├── qs@2.2.4
├── on-finished@2.1.0 (ee-first@1.0.5)
├── depd@0.4.5
├── iconv-lite@0.4.4
└── type-is@1.5.3 (mime-types@2.0.3)

request@2.49.0 node_modules\request
├── caseless@0.8.0
├── json-stringify-safe@5.0.0
├── aws-sign2@0.5.0
├── forever-agent@0.5.2
├── stringstream@0.0.4
├── tunnel-agent@0.4.0
├── oauth-sign@0.5.0
├── node-uuid@1.4.2
├── qs@2.3.3
├── mime-types@1.0.2
├── combined-stream@0.0.7 (delayed-stream@0.0.5)
├── form-data@0.1.4 (mime@1.2.11, async@0.9.0)
├── bl@0.9.3 (readable-stream@1.0.33)
├── tough-cookie@0.12.1 (punycode@1.3.2)
├── http-signature@0.10.0 (assert-plus@0.1.2, asn1@0.1.11, ctype@0.5.2)
└── hawk@1.1.1 (cryptiles@0.2.2, sntp@0.2.4, boom@0.4.2, hoek@0.9.1)

express@4.9.8 node_modules\express
├── cookie@0.1.2
├── fresh@0.2.4
├── utils-merge@1.0.0
├── merge-descriptors@0.0.2
├── cookie-signature@1.0.5
├── escape-html@1.0.1
├── range-parser@1.0.2
├── vary@1.0.0
├── media-typer@0.3.0
├── finalhandler@0.3.2
├── methods@1.1.0
├── parseurl@1.3.0
├── serve-static@1.7.1
├── content-disposition@0.5.0
├── path-to-regexp@0.1.3
├── depd@1.0.0
├── on-finished@2.1.1 (ee-first@1.1.0)
├── qs@2.3.0
├── debug@2.1.0 (ms@0.6.2)
├── proxy-addr@1.0.4 (forwarded@0.1.0, ipaddr.js@0.1.5)
├── etag@1.5.1 (crc@3.2.1)
├── send@0.10.1 (destroy@1.0.3, ms@0.6.2, mime@1.2.11)
├── accepts@1.1.3 (negotiator@0.4.9, mime-types@2.0.3)
└── type-is@1.5.3 (mime-types@2.0.3)

jade@1.6.0 node_modules\jade
├── character-parser@1.2.0
├── commander@2.1.0
├── void-elements@1.0.0
├── mkdirp@0.5.0 (minimist@0.0.8)
├── transformers@2.1.0 (promise@2.0.0, css@1.0.8, uglify-js@2.2.5)
├── constantinople@2.0.1 (uglify-js@2.4.15)
├── with@3.0.1 (uglify-js@2.4.15)
└── monocle@1.1.51 (readdirp@0.2.5)

Doug.wilson@IN5358 ~/test/compressionTest (master)
$ node testHEAD.js
head request done

Doug.wilson@IN5358 ~/test/compressionTest (master)
$ node -v
v0.11.14

And the window with the server running:

Doug.wilson@IN5358 ~/test/compressionTest (master)
$ npm start

> compressionTest@0.0.0 start c:\Users\doug.wilson\test\compressionTest
> node ./bin/www

HEAD / 200 622.418 ms - 170

[mingoing]

I think it might be a bug on node 0.11.14, using 0.10 will be ok.

[dougwilson]

As you can see in my logs above, I used 0.11.14, not 0.10.

[dougwilson]

I had looked at it more since I posted me running your app on Node.js 0.11.14 above, and I haven't been able to reproduce the issue (yes, even on 0.11.14). Can you try a few things?

1. Completely uninstall your Node.js 0.11.14 and reinstall it. Perhaps you have a messed up version or something?
2. Try to reproduce it on a completely different machine with your repo.
3. Use the official binary from Node.js: http://nodejs.org/dist/v0.11.14/ and see if it still happens.

[dougwilson]

@wlsy I can reproduce it now. This is the reason I could not before: nodejs/node-v0.x-archive#8855