Why don't export default filter to user?

[hefangshi]

I wanna set some custom filter for specific request, but I wanna use default filter for others.

But the module.exports override the exports.filter function, so i can't call it in my filter function.

[dougwilson]

The module.exports is just the default; pass in your filter function as the filter option to the middleware.

But the module.exports override the exports.filter function, so i can't call it in my filter function.

I'm not sure what this means.

[dougwilson]

I think this should help you:

var compression = require('compression')
var express = require('express')

var app = express()

// compress
app.use(compression({filter: function (req, res) {
  if (some_condition) {
    return false // never compress
  } else {
    return compression.filter(req, res) // use default filter
  }
}}))

[hefangshi]

var compression = require('compression');
console.log(compression.filter);

try this please.

the code defined the module.exports after exports.filter, so the exports.filter is undefined.

[dougwilson]

the code defined the module.exports after exports.filter, so the exports.filter is undefined.

ah, I gotcha now. very sorry about that!

[dougwilson]

Ok, looks like it has been that way since the initial commit, which is good, because I can basically fix this as a new feature :)

[dougwilson]

Alright, it's been added :) It hasn't been released just yet, but it'll be in version 1.3.0.