Skip to content

Conversation

@olsonpm
Copy link

@olsonpm olsonpm commented Feb 5, 2015

No description provided.

@dougwilson dougwilson added the pr label Feb 5, 2015
@dougwilson
Copy link
Contributor

Z_DEFAULT_COMPRESSION requests a default compromise between speed and compression (currently equivalent to level 6).

We can just add that directly into the readme, rather than a esoteric link :)

@dougwilson dougwilson self-assigned this Feb 5, 2015
@dougwilson dougwilson added the docs label Feb 5, 2015
@Fishrock123
Copy link
Contributor

Hmmm, I thought it defaulted to level 7?

@dougwilson
Copy link
Contributor

Hmmm, I thought it defaulted to level 7?

Maybe. I only took it from the linked documentation, which may or may not apply to the bundled version of zlib in Node.js. It's easy to test: compress something with -1, then compress it with 6. Are they the same bytes? Then that's the default :)

@Fishrock123
Copy link
Contributor

Hmm, looks like it should be 6. My bad.

@olsonpm
Copy link
Author

olsonpm commented Feb 5, 2015

Yeah, i didn't include the number because i thought that was the only reason to
disclude it in the first place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants