Experimental: Fix reloading not working for content_scripts indexes #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
better-content-scripts
branch
from
4a43088 to
86d3054
Compare
cezaraugusto
force-pushed
the
better-content-scripts
branch
from
86d3054 to
4fcc39d
Compare
commit: |
commit: |
cezaraugusto
force-pushed
the
main
branch
2 times, most recently
from
f53897b to
b218988
Compare
Member
Author
|
this is fixed in #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, indexes defined in
content_scriptsfiles are not reloaded at all for framework-specific templates (we must import aContentAppfor them) and have a wrong behavior (does not clean-up previous HMR code) for non-framework templates. This PR is an attempt to fix that.Related to awesome-webextension/webpack-target-webextension#46