Improve typespec to allow integers to be encoded in RLP #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Yellow Paper speaks about only binaries and lists as the types of data which can be RLP encoded, but the actual test cases from Ethereum allow for integers to be encoded directly (which, I guess are basically the same thing as bitstrings). In either case, we allow for this now in our typespecs.
ayrat555
approved these changes
Aug 4, 2017
masonforest
pushed a commit
that referenced
this pull request
Apr 13, 2018
Improve typespec to allow integers to be encoded in RLP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Yellow Paper speaks about only binaries and lists as the types of data which can be RLP encoded, but the actual test cases from Ethereum allow for integers to be encoded directly (which, I guess are basically the same thing as bitstrings). In either case, we allow for this now in our typespecs.