-
Notifications
You must be signed in to change notification settings - Fork 12
feat: API review #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
260ec17
feat: export createPlugin instead of the static ExtismPlugin.new
mhmd-azeez 1a3e8c9
fix tests
mhmd-azeez 67f994a
implement CurrentPlugin
mhmd-azeez c25f89d
use ts for deno
mhmd-azeez eeb0544
use top level statements for deno
mhmd-azeez 1a06f4d
cleanup
mhmd-azeez 940eeb1
Merge branch 'main' into feat/api-review
mhmd-azeez 87d8fc2
feat: turn ExtismPluginOptions into an interface
mhmd-azeez 2d18ba3
pass in CurrentPlugin to the first argument
mhmd-azeez 9b208b1
don't use syncfetch in fetchWasm
mhmd-azeez 2e5bca7
use WebAssembly.instantiateStreaming when possible
mhmd-azeez 9cd8bf5
apply chris's suggestions
mhmd-azeez 6c207af
use default export in Node too
mhmd-azeez b4428bb
unify ManifestWasmFile into ManifestWasmUrl
mhmd-azeez 9081289
assume all URLs are http in the browser
mhmd-azeez 5e3356d
fix examples
mhmd-azeez 7904062
allow users to pass in a string
mhmd-azeez 928db46
remove node-fetch dependency
mhmd-azeez 381330c
Merge branch 'main' into feat/api-review
mhmd-azeez 4835c8a
fix: remove unnecessary CurrentPlugin import
mhmd-azeez f985da7
Merge branch 'feat/api-review' of https://github.com/extism/js-sdk in…
mhmd-azeez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import createPlugin from '../src/deno/mod.ts' | ||
|
|
||
| const filename = Deno.args[0] || "wasm/hello.wasm"; | ||
| const funcname = Deno.args[1] || "run_test"; | ||
| const input = Deno.args[2] || "this is a test"; | ||
| const wasm = { | ||
| url: filename | ||
| } | ||
|
|
||
| const plugin = await createPlugin(wasm, { | ||
| useWasi: true, | ||
| config: { | ||
| "thing": "testing" | ||
| } | ||
| }); | ||
|
|
||
| const res = await plugin.call(funcname, new TextEncoder().encode(input)); | ||
| const s = new TextDecoder().decode(res.buffer); | ||
| console.log(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write this from the user's perspective? how do we import from the npm module? If i'm using typescript how do i get the types I need?