Build errors

[darkterminal]

cargo build --release

PHP Version 8.4

cargo build --release                          
   Compiling ext-php-rs v0.13.1 (https://github.com/davidcole1340/ext-php-rs.git?branch=master#a77adcde)
error[E0560]: struct `_zend_function_entry` has no field named `doc_comment`
  --> /home/yes/iam/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/builders/function.rs:59:17
   |
59 |                 doc_comment: ptr::null(),
   |                 ^^^^^^^^^^^ `_zend_function_entry` does not have this field
   |
   = note: all struct fields are already assigned

error[E0560]: struct `_zend_function_entry` has no field named `frameless_function_infos`
  --> /home/darkterminal/fs-museum/DARK-STATION/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/builders/function.rs:61:17
   |
61 |                 frameless_function_infos: ptr::null(),
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^ `_zend_function_entry` does not have this field
   |
   = note: all struct fields are already assigned

error[E0560]: struct `_zend_function_entry` has no field named `doc_comment`
  --> /home/yes/iam/DARK-STATION/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/builders/function.rs:87:17
   |
87 |                 doc_comment: ptr::null(),
   |                 ^^^^^^^^^^^ `_zend_function_entry` does not have this field
   |
   = note: all struct fields are already assigned

error[E0560]: struct `_zend_function_entry` has no field named `frameless_function_infos`
  --> /home/yes/iam/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/builders/function.rs:89:17
   |
89 |                 frameless_function_infos: ptr::null(),
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^ `_zend_function_entry` does not have this field
   |
   = note: all struct fields are already assigned

error[E0560]: struct `_zend_function_entry` has no field named `doc_comment`
  --> /home/yes/iam/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/zend/function.rs:42:13
   |
42 |             doc_comment: ptr::null(),
   |             ^^^^^^^^^^^ `_zend_function_entry` does not have this field
   |
   = note: all struct fields are already assigned

error[E0560]: struct `_zend_function_entry` has no field named `frameless_function_infos`
  --> /home/yes/iam/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/zend/function.rs:44:13
   |
44 |             frameless_function_infos: ptr::null(),
   |             ^^^^^^^^^^^^^^^^^^^^^^^^ `_zend_function_entry` does not have this field
   |
   = note: all struct fields are already assigned

error[E0308]: mismatched types
   --> /home/yes/iam/.cargo/git/checkouts/ext-php-rs-0adfd3c26f55092c/a77adcd/src/zend/handlers.rs:244:36
    |
244 | ...                   if zend_is_true(&mut zv) {
    |                          ^^^^^^^^^^^^^^^^^^^^^ expected `bool`, found `i32`

Some errors have detailed explanations: E0308, E0560.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `ext-php-rs` (lib) due to 7 previous errors

[Xenira]

Do you have the PHP environment variable set?

This can happen if the bindings were generated using a different version than the system one.

[darkterminal]

Yes, and I've this:

[yoramdelangen]

These error happening due to PHP 8.4. @Xenira in my PR #337 I added these new field for PHP 8.4.

@darkterminal try to build against master branch

[darkterminal]

@yoramdelangen The error I showed happens when I build from the master branch. Even when I use the latest release version, I still get the same issue. Is support for PHP 8.4 not fully implemented yet?

Thank for everyone who keep maintain this incredible project!

[Xenira]

@yoramdelangen pretty sure its a different error.

Will have a look once i am home

[darkterminal]

Now the build it's working using my patch version for PHP8.4 after follow the errors and remove doc_comment: ptr::null() and frameless_function_infos: ptr::null(). And change the statement in src/zend/handlers.rs from if zend_is_true(&mut zv) to if zend_is_true(&mut zv) != 0

And after build is passed, then I got incompatible API:

PHP Warning:  PHP Startup: libsql_php: Unable to initialize module
Module compiled with module API=20230831
PHP    compiled with module API=20240924
These options need to match
 in Unknown on line 

[darkterminal]

Let me clarify... This is pure my skill issue and truly embarrassing.

So, I want to build my extension in PHP8.4 using ext-php-rs@0.13.1 then I run this command (while I am currently in PHP8.3):

sudo update-alternatives --config php
There are 6 choices for the alternative php (providing /usr/bin/php).

  Selection    Path                  Priority   Status
------------------------------------------------------------
  0            /usr/bin/php.default   100       auto mode
  1            /usr/bin/php.default   100       manual mode
  2            /usr/bin/php8.0        80        manual mode
  3            /usr/bin/php8.1        81        manual mode
  4            /usr/bin/php8.2        82        manual mode
  5            /usr/bin/php8.3        83        manual mode
* 6            /usr/bin/php8.4        84        manual mode

To switch from 8.3 to 8.4 then I run

cargo build --release

This is my mistake! I ran that command without changing the php-config to use the PHP8.4. That's why I got:

PHP Warning:  PHP Startup: libsql_php: Unable to initialize module
Module compiled with module API=20230831
PHP    compiled with module API=20240924
These options need to match
 in Unknown on line 

Cz when I run php -i | grep "PHP API" it's show the correct API version for PHP8.4

$ php -i | grep "PHP API"
PHP API => 20240924

but the php-config show incorrect API version

$ php-config --phpapi    
20230831

The simple fix is (this is really stupid) just switch the php-config into correct PHP Version

$ sudo update-alternatives --config php-config
There are 5 choices for the alternative php-config (providing /usr/bin/php-config).

  Selection    Path                         Priority   Status
------------------------------------------------------------
  0            /usr/bin/php-config.default   100       auto mode
  1            /usr/bin/php-config.default   100       manual mode
  2            /usr/bin/php-config8.0        80        manual mode
  3            /usr/bin/php-config8.2        82        manual mode
  4            /usr/bin/php-config8.3        83        manual mode
* 5            /usr/bin/php-config8.4        84        manual mode

And run build command:

PHP_CONFIG=$(which php-config) cargo build --release

That's it! OhMyPunk! Problem solved and case is closed!

Thanks for @yoramdelangen and @Xenira

Big Hug

• .darkterminal

[Xenira]

@darkterminal glad you found the solution.

Should work without PHP_CONFIG=$(which php-config). If it is not set it will use it using the $PATH.

[darkterminal]

Yes, but it's reminds my skill issue.