Embed::run_script missing zend_destroy_file_handle call

[el7cosmos]

Description

Embed::run_script missing call zend_destroy_file_handle() and may cause a memory leak.

Example leak with valgrind:

==648== 112 bytes in 2 blocks are definitely lost in loss record 34 of 87
==648==    at 0x488545C: malloc (vg_replace_malloc.c:446)
==648==    by 0x513DAAB: __zend_malloc (zend_alloc.c:3294)
==648==    by 0x513C1EF: _emalloc (zend_alloc.c:2740)
==648==    by 0x532B55F: zend_string_alloc (zend_string.h:176)
==648==    by 0x532B5D3: zend_string_init (zend_string.h:198)
==648==    by 0x532BAEB: zend_stream_init_filename (zend_stream.c:73)
==648==    by 0x28F73B: ext_php_rs::embed::Embed::run_script (mod.rs:105)
==648==    by 0x2E2383: pasir::service::php::execute_php::{{closure}}::{{closure}} (php.rs:182)
==648==    by 0x214703: ext_php_rs::zend::try_catch::panic_wrapper::{{closure}} (try_catch.rs:17)
==648==    by 0x25A207: std::panicking::catch_unwind::do_call (panicking.rs:590)
==648==    by 0x1EEF07: __rust_try (in /app/target/debug/pasir)
==648==    by 0x1EDCF3: std::panic::catch_unwind (panicking.rs:553)

Checklist

Check the boxes that apply (put an x in the brackets, like [x]). You can also check boxes after the PR is created.

• I have read the contribution guidelines.
• I have added tests that prove my code works as expected.
• I have added documentation if applicable.
• I have added a migration guide if applicable.

❤️ Thank you for your contribution!

[coveralls]

Pull Request Test Coverage Report for Build 18141211519

Details

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.007%) to 27.728%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/embed/mod.rs	0	1	0.0%

Totals
Change from base Build 18140982423:	-0.007%
Covered Lines:	1156
Relevant Lines:	4169

---

💛 - Coveralls

[ptondereau]

Good catch!
Could you also fix clippy errors? If not, we'll do it in another PR
Thank you

[el7cosmos]

I can try to fix Clippy errors

[Xenira]

@el7cosmos sorry for the long delay. Fixed clippy, embed and bindings in master.