Skip to content

Conversation

@ptondereau
Copy link
Member

@ptondereau ptondereau commented Oct 28, 2025

Breaking changes

Mostly #[unsafe(no_mangle)]

Addition

  • Added more tests for variadic arguments for array conversion

@ptondereau ptondereau self-assigned this Oct 28, 2025
@ptondereau ptondereau force-pushed the chore/bump-edition-2024 branch from fb50c10 to 9fccf6e Compare October 28, 2025 12:37
@coveralls
Copy link

coveralls commented Oct 28, 2025

Pull Request Test Coverage Report for Build 18881634229

Details

  • 10 of 91 (10.99%) changed or added relevant lines in 14 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 31.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/zval.rs 0 1 0.0%
src/types/array/mod.rs 0 2 0.0%
windows_build.rs 0 2 0.0%
crates/cli/src/lib.rs 0 5 0.0%
src/describe/stub.rs 0 6 0.0%
src/types/class_object.rs 0 8 0.0%
crates/macros/src/function.rs 0 21 0.0%
src/zend/handlers.rs 0 36 0.0%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/function.rs 1 0.0%
Totals Coverage Status
Change from base Build 18881595925: -0.1%
Covered Lines: 1356
Relevant Lines: 4369

💛 - Coveralls

@ptondereau ptondereau force-pushed the chore/bump-edition-2024 branch 3 times, most recently from 639917a to 9528032 Compare October 28, 2025 13:28
@ptondereau ptondereau marked this pull request as ready for review October 28, 2025 13:38
@ptondereau ptondereau changed the title chore(rust): bump Rust edtion to 2024 chore(rust): bump Rust edition to 2024 Oct 28, 2025
Xenira
Xenira previously approved these changes Oct 28, 2025
@ptondereau ptondereau force-pushed the chore/bump-edition-2024 branch from 9528032 to 610ff3d Compare October 28, 2025 16:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18904778156

Details

  • 10 of 91 (10.99%) changed or added relevant lines in 14 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 31.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/zval.rs 0 1 0.0%
src/types/array/mod.rs 0 2 0.0%
windows_build.rs 0 2 0.0%
crates/cli/src/lib.rs 0 5 0.0%
src/describe/stub.rs 0 6 0.0%
src/types/class_object.rs 0 8 0.0%
crates/macros/src/function.rs 0 21 0.0%
src/zend/handlers.rs 0 36 0.0%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/function.rs 1 0.0%
Totals Coverage Status
Change from base Build 18903543486: -0.1%
Covered Lines: 1356
Relevant Lines: 4369

💛 - Coveralls

@ptondereau
Copy link
Member Author

tested against my project https://github.com/ptondereau/biscuit-php and it build fine

@ptondereau ptondereau merged commit 3f6595d into master Oct 29, 2025
45 checks passed
@ptondereau ptondereau deleted the chore/bump-edition-2024 branch October 29, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants