Skip to content

Conversation

@Qard
Copy link
Contributor

@Qard Qard commented Oct 29, 2025

Description

I need send_headers (plural) rather than just send_header (singular) to be able to know when sending of all headers completes. I'm using this to support streaming so I can return a response body stream as soon as headers are available and then I can read from it while the request continues to be processed in another thread.

Checklist

Check the boxes that apply (put an x in the brackets, like [x]). You can also check boxes after the PR is created.

❤️ Thank you for your contribution!

@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 18922539846

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 31.084%

Totals Coverage Status
Change from base Build 18909521820: 0.05%
Covered Lines: 1359
Relevant Lines: 4372

💛 - Coveralls

@Qard Qard force-pushed the add-sapi-send-headers branch from d98f4e5 to e933246 Compare October 29, 2025 21:24
@ptondereau
Copy link
Member

Seems good enough, thanks!

@ptondereau ptondereau merged commit d5022a1 into extphprs:master Oct 29, 2025
43 checks passed
@Qard Qard deleted the add-sapi-send-headers branch October 29, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants