feat: add format #316
Merged
feat: add format #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almenon
approved these changes
Dec 6, 2025
Collaborator
Almenon
left a comment
Almenon
left a comment
There was a problem hiding this comment.
Looks good, thanks. The only request I have is to ignore the package-lock.json file, that's autogenerated so no point in prettier trying to format it.
https://prettier.io/docs/ignore
Edit: Actually, I can add this on my own. Approving!
Collaborator
|
also note there's more work if you want to take it on: #317 |
Contributor
Author
|
Thank you for the review and for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on #295 and noticed there's no formatterconfigured.
This made it difficult to ensure consistent code style.
This PR adds Prettier for formatting
Let me know if you have any preferences on the configuration - happy to adjust.