Skip to content

Conversation

eygraber
Copy link
Owner

@eygraber eygraber requested a review from Copilot September 28, 2025 06:47
@eygraber eygraber self-assigned this Sep 28, 2025
@eygraber eygraber added the bug Something isn't working label Sep 28, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues introduced in AndroidX SQLite 2.6.1 by modifying the order of PRAGMA statements and replacing custom writePragma functions with the standard execSQL method.

  • Replaces custom writePragma function with standard execSQL calls
  • Reorders PRAGMA statements to ensure foreign_keys comes after journal_mode
  • Adds comprehensive tests to verify foreign key behavior during database creation and migration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
ConnectionPool.kt Replaces writePragma with execSQL and reorders PRAGMA statements to work around AndroidX SQLite 2.6.1 issues
AndroidxSqliteDriver.kt Simplifies foreign key handling during migrations by removing nested transactions and moving user_version updates
AndroidxSqliteMigrationTest.kt Adds tests to verify foreign keys are properly disabled during migration and re-enabled afterward
AndroidxSqliteCreationTest.kt Adds tests to verify foreign keys are properly disabled during creation and re-enabled afterward

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eygraber eygraber merged commit 43faddb into master Sep 28, 2025
8 checks passed
@eygraber eygraber deleted the more-fixes branch September 28, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant