Fix api to use passed params #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
commented
Jun 13, 2023
| async getUserByScreenName(param: getUserByScreenNameParam): Promise<UserApiUtilsResponse> { | ||
| const args = { | ||
| screenName: param.screenName, | ||
| screen_name: param.screenName, |
Contributor
Author
There was a problem hiding this comment.
screenName is not recognized by Twitter. I looked in the request variables and apparently Twitter uses screen_name instead.
fa0311
approved these changes
Jun 14, 2023
Owner
|
Thank you! That was my typo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
twitter-openapi-typescriptconstantly falls back to using the default values for all parameters no matter what you pass. The result is that you always get data about Elon Musk. This PR fixes that.