Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix formatWebpackMessages to return all formatted messages instead of just one error. #2834
I propose this change to
I propose this change because it's really surprising that when you call a function that is supposed to format messages that actually formats and removes messages.
I moved the removal of messages where they're displayed. That makes it clearer why you see only one single error and not all the errors that occured.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at firstname.lastname@example.org. Thanks!
Sure I can do that, I'm currently in vacation so I'll do that as soon as I get back Obtenez Outlook pour iOS<https://aka.ms/o0ukef>…
________________________________ From: Joe Haddad <email@example.com> Sent: Wednesday, August 2, 2017 3:15:01 AM To: facebookincubator/create-react-app Cc: Stéphane Goetz; Author Subject: Re: [facebookincubator/create-react-app] fix formatWebpackMessages to return all formatted messages instead of just one error. (#2834) Actually, I think we need to change this in webpackHotDevClient<https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/webpackHotDevClient.js> too, could you please do that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2834 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAS5WgXj1Lx4ihuUlzSnPRwtJt-1oC1Iks5sT82VgaJpZM4Of1eS>.
Okay, I looked into it, and webpackHotDevClient doesn't need any change :
The first usage of
And while the second call (https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/webpackHotDevClient.js#L268) is for errors, it already only takes the first error (https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/webpackHotDevClient.js#L274)
And then it wants to log the rest of errors, that's probably where you want to keep all of them as well.