Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): pin version of babel-plugin-dynamic-import-node to 2.3.0 #3742

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 13, 2020

Motivation

After merge #3740, there was again critical dependency issue related the PWA plugin.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Netlify deploy logs.

Related PRs

@lex111 lex111 requested a review from slorber as a code owner November 13, 2020 14:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2020
@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for docusaurus-2 ready!

Built with commit d116926

https://deploy-preview-3742--docusaurus-2.netlify.app

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 13, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 13, 2020

not in the logs so hopefully it works this time :D

@slorber slorber merged commit 7c97dad into master Nov 13, 2020
@Simek
Copy link
Contributor

Simek commented Nov 13, 2020

@lex111 It probably won't help unless you pin 2.3.3 to point to the 2.3.0 or downgrade the babel packages which includes the 2.3.3 as minimum required version in dependencies.

Screenshot 2020-11-13 152632

@lex111 lex111 deleted the lex111/bable-import-pin branch November 13, 2020 22:58
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants