Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): add info about development on github codespaces #6883

Merged
merged 8 commits into from
Mar 10, 2022
Merged

docs(cli): add info about development on github codespaces #6883

merged 8 commits into from
Mar 10, 2022

Conversation

vedantmgoyal9
Copy link
Contributor

@facebook-github-bot
Copy link
Contributor

Hi @vedantmgoyal2009!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vedantmgoyal9
Copy link
Contributor Author

@facebook-github-bot recheck now.

@Josh-Cena
Copy link
Collaborator

@vedantmgoyal2009 The CLA bot updates the PR status automatically. It doesn't get triggered by anything.

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are far over-estimating the number of people who use GitHub codespaces. You are the first so far to report this problem either on GitHub or Discord. Therefore, I don't think it makes sense to put this in installation, which everyone has to read.

What about moving to the CLI documentation instead?

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 9f180c7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62295843cda53000094f1278

😎 Browse the preview: https://deploy-preview-6883--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6883--docusaurus-2.netlify.app/

@vedantmgoyal9
Copy link
Contributor Author

vedantmgoyal9 commented Mar 9, 2022

I do not have any problem in moving it to CLI docs but am just putting my thoughts here.

I think there are a considerable number of developers on GitHub that uses and even provide support for development on Codespaces and do have .devcontainer files for easier development. For instance, I can remember of Oh-my-posh (https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/CONTRIBUTING.md#codespaces--devcontainer-development-environment)

@Josh-Cena
Copy link
Collaborator

Yes, but that's CONTRIBUTING, which is developer-facing, not user-facing.

We have a lot of casual users who don't use these toolchains—they have a text editor, Node and NPM, and that's it. We don't want to clutter the installation guide (and any introductory content) with these niche use-cases. So yes, moving to CLI docs is the most sensible.

@vedantmgoyal9
Copy link
Contributor Author

I guess a section under "Advanced Guides" would make more sense?

@Josh-Cena
Copy link
Collaborator

No, because "advanced" is relative to users' understanding of our infrastructure, not relative to their toolchain's advancedness :)

@vedantmgoyal9 vedantmgoyal9 changed the title docs(installataion): add info about development on github codespaces docs(cli): add info about development on github codespaces Mar 9, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 9, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@@ -50,6 +50,16 @@ Please note that some functionality (for example, anchor links) will not work in

:::

:::info Running on GitHub Codespaces
Copy link
Collaborator

@slorber slorber Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to add this here, but I'd like the block to be quite generic

It does not apply only to codespace, and this option is also available in other frameworks: CRA, Gatsby, NextJS...

See for example
https://nextjs.org/docs/api-reference/cli#development
gatsbyjs/gatsby#8149

@Josh-Cena Josh-Cena merged commit 63caeb6 into facebook:main Mar 10, 2022
@vedantmgoyal9
Copy link
Contributor Author

Thank you🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants