-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cli): add info about development on github codespaces #6883
Conversation
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@facebook-github-bot recheck now. |
@vedantmgoyal2009 The CLA bot updates the PR status automatically. It doesn't get triggered by anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are far over-estimating the number of people who use GitHub codespaces. You are the first so far to report this problem either on GitHub or Discord. Therefore, I don't think it makes sense to put this in installation, which everyone has to read.
What about moving to the CLI documentation instead?
✔️ [V2] 🔨 Explore the source changes: 9f180c7 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62295843cda53000094f1278 😎 Browse the preview: https://deploy-preview-6883--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6883--docusaurus-2.netlify.app/ |
I do not have any problem in moving it to CLI docs but am just putting my thoughts here. I think there are a considerable number of developers on GitHub that uses and even provide support for development on Codespaces and do have |
Yes, but that's We have a lot of casual users who don't use these toolchains—they have a text editor, Node and NPM, and that's it. We don't want to clutter the installation guide (and any introductory content) with these niche use-cases. So yes, moving to CLI docs is the most sensible. |
I guess a section under "Advanced Guides" would make more sense? |
No, because "advanced" is relative to users' understanding of our infrastructure, not relative to their toolchain's advancedness :) |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
website/docs/cli.md
Outdated
@@ -50,6 +50,16 @@ Please note that some functionality (for example, anchor links) will not work in | |||
|
|||
::: | |||
|
|||
:::info Running on GitHub Codespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to add this here, but I'd like the block to be quite generic
It does not apply only to codespace, and this option is also available in other frameworks: CRA, Gatsby, NextJS...
See for example
https://nextjs.org/docs/api-reference/cli#development
gatsbyjs/gatsby#8149
Thank you🎉🎉 |
Motivation
Have you read the Contributing Guidelines on pull requests?
Yes.
Related PRs