Expected node root to have a parent

[zkuzmic]

Hey there,

I've been really struggling with finding the root cause of this error: Expected node root to have a parent..

It's being triggered by the getParentOrThrow() on (line 372 of LexicalListItemNode.ts) where it is trying to find the parent ListItemNode's parent. In this case, it seems that ListItemNode is actually a direct descendant of the RootNode, so trying to find RootNode's parent throws the error. Comically, there's a comment in the source code just above that line: ListItemNode should always have a ListNode for a parent.

How can this be? I don't think Lexical would let me add a ListeItemNode as a direct descendant of RootNode even if I tried to do it manually.

Also, I should add that I'm not sure what action is causing this unfortunately. I'm seeing the error in prod but still haven't been able to reproduce locally.

Open to any and all suggestions on how to diagnose this!

[zkuzmic]

For anyone wondering what the issue was here, I found the root cause.

In some instances, we were accepting custom HTML, parsing it, creating nodes with $generateNodesFromDOM, and then appending those to the RootNode. If the custom HTML was just <li>listitem</li>, that element would be created as a direct descendant of RootNode (and would lead to the error mentioned above).

In our custom parsing step, I added a check to see if any of RootNode's children is a ListItemNode, and if so, wrap it in a ListNode.