-
Notifications
You must be signed in to change notification settings - Fork 123
Moved prefix to <head> #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The source for ogp.me has the `prefix` on the head, so it should be in the example to. This makes it closer to the tags, and is in accordance with feedback from @ptarjan's comment [here](http://stackoverflow.com/questions/8235687/open-graph-namespace-declaration-html-with-xmlns-or-head-prefix#comment16029564_8241755)
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
|
@chuckreynolds ping? |
|
@RichardLitt sup man? fwiw I don't have any ownership of this repo at all so I can't push things along :) or if you needed something else lmk. |
|
Ah, my bad, too quick on the notification there. Thanks anyway. :) Facebook, what's up with this? A year old PR is pretty long, eh? |
|
Not unusual. they abandoned the FB plugin and this site seems very slow to get updates. |
|
A year late :) I actually did this intentionally as people who are just copying and pasting are safer by putting it on the The chance of someone redefining the |
|
Interesting. Maybe a comment would be good, in the code, stating that this was intentional? Comments are cheap. |
|
@RichardLitt well a comment in the thing they paste in would be wasted as I'm just catering to the copy-pasters. I'm happy to have this PR serve as a comment. |
|
Sounds good to me. |
The source for ogp.me has the
prefixon the head, so it should be in the example too. This makes it closer to the tags, and is in accordance with feedback from @ptarjan's comment here