Skip to content

Conversation

@andrewnicols
Copy link
Member

https://www.w3.org/TR/webdriver/#switch-to-window

Let handle be the result of getting the property "handle" from the parameters argument.

Apologies but I'm not quite sure how best to unit test this.

@facebook-github-bot
Copy link

Hi andrewnicols! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@andrewnicols
Copy link
Member Author

CLA now signed.

Copy link
Collaborator

@OndraM OndraM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for the PR! But we need to take care of both protocols and not break things :).

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andrewnicols andrewnicols force-pushed the switchtowindow branch 3 times, most recently from 47229f0 to 4d8a5ff Compare November 21, 2019 01:40
@andrewnicols
Copy link
Member Author

As I've now come across a second function in the RemoteTargeLocator which needs to maintain b/c, I've passed the isW3cCompliant argument as an optional 3rd argument to the constructor.

This change is on a separate commit shared between this issue and #684

@andrewnicols andrewnicols requested a review from OndraM November 21, 2019 01:45
Copy link
Collaborator

@OndraM OndraM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! But let me please leave this PR open for just a while - I'd like to add some tests before merging this, because we are obviously missing them :).

The W3C specification dictates that the parameter used to select the
window should be named `handle`.

Source: https://www.w3.org/TR/webdriver/#switch-to-window
@OndraM OndraM merged commit 98686d9 into php-webdriver:community Nov 26, 2019
@OndraM OndraM added this to the 1.8.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants