-
Notifications
You must be signed in to change notification settings - Fork 849
Switch to window takes a handle #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi andrewnicols! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
CLA now signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thanks for the PR! But we need to take care of both protocols and not break things :).
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
47229f0 to
4d8a5ff
Compare
|
As I've now come across a second function in the RemoteTargeLocator which needs to maintain b/c, I've passed the isW3cCompliant argument as an optional 3rd argument to the constructor. This change is on a separate commit shared between this issue and #684 |
OndraM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! But let me please leave this PR open for just a while - I'd like to add some tests before merging this, because we are obviously missing them :).
4d8a5ff to
a653d3f
Compare
ca502f6 to
f3bca12
Compare
The W3C specification dictates that the parameter used to select the window should be named `handle`. Source: https://www.w3.org/TR/webdriver/#switch-to-window
f3bca12 to
75b72f3
Compare
https://www.w3.org/TR/webdriver/#switch-to-window
Apologies but I'm not quite sure how best to unit test this.