Add all W3C WebDriver exceptions #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
approved these changes
Nov 24, 2019
Member
andrewnicols
left a comment
andrewnicols
left a comment
There was a problem hiding this comment.
These changes look good to me.
Have compared the list of errors on the W3C list and all are complet.
OndraM
force-pushed
the
w3c-exceptions
branch
from
7dc46dd to
13895bc
Compare
Collaborator
Author
|
Failed builds are not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all W3C WebDriver exceptions according to https://w3c.github.io/webdriver/#errors. Those which didn't make it to the new standard are marked as deprecated.Ref. #469
Upgrade notice:
Those deprecated exceptions are already not thrown when using W3C WebDriver mode (default on Chrome etc.). However, if there is equivalent W3C WebDriver exception, the "old one" inherit from the new W3C-compatible one, making it BC compatible. But you can safely replace the old exception with the new one. If the exception is deprecated and does not inherits from a W3C-compatible exception, is was removed from WebDriver protocol and will never be thrown, you should update your code.