Add switch to parent frame command #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
andrewnicols
force-pushed
the
parentFrame
branch
2 times, most recently
from
c17102d to
b7a5fc9
Compare
OndraM
requested changes
Dec 22, 2019
andrewnicols
force-pushed
the
parentFrame
branch
2 times, most recently
from
1e45b6e to
dd588d7
Compare
OndraM
approved these changes
Dec 24, 2019
Collaborator
OndraM
left a comment
OndraM
left a comment
There was a problem hiding this comment.
The commented interface was confusing codestyle check, so I put it inside inline comments to get it it actually ignored.
Otherwise LGTM, let's wait for the CI 👌 .
Thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #683