Skip to content

Conversation

@andrewnicols
Copy link
Member

I've included an extra commit here because the W3C mode doesn't take any arguments but JSONWire does but we were still including the args still.

@OndraM OndraM added this to the 1.8.0 milestone Dec 22, 2019
@andrewnicols andrewnicols force-pushed the fullscreenWindow branch 2 times, most recently from ed8d076 to fd396c5 Compare December 24, 2019 08:09
@andrewnicols
Copy link
Member Author

I think that this should be ready to land. I've had to exclude edge for now because SauceLabs seems to be running an old version (their docs suggest EdgeHTML 18) which does not support the fullscreen command.

Microsoft are now releasing Edge based on Blink so we should be able to remove this exclusion when SauceLabs bump their edge versions.

@andrewnicols
Copy link
Member Author

Thanks,

That makes total sense. I've changed it to throw an exception and have modified the test to skip for the JsonWire protocol.

@OndraM OndraM merged commit 393f30c into php-webdriver:community Jan 20, 2020
@OndraM
Copy link
Collaborator

OndraM commented Jan 20, 2020

Thanks @andrewnicols!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants