Skip to content

Commit d524f81

Browse files
authored
Enable Performance panel by default (#216)
1 parent 62f76df commit d524f81

File tree

5 files changed

+0
-38
lines changed

5 files changed

+0
-38
lines changed

front_end/core/rn_experiments/experimentsImpl.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,6 @@ Instance.register({
185185
enabledByDefault: ({ isReactNativeEntryPoint }) => isReactNativeEntryPoint,
186186
});
187187

188-
Instance.register({
189-
name: RNExperimentName.ENABLE_PERFORMANCE_PANEL,
190-
title: 'Enable Performance panel',
191-
unstable: true,
192-
enabledByDefault: ({ isReactNativeEntryPoint }) => !isReactNativeEntryPoint,
193-
});
194-
195188
Instance.register({
196189
name: RNExperimentName.ENABLE_NETWORK_PANEL,
197190
title: 'Enable Network panel',

front_end/core/root/Runtime.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ export const experiments = new ExperimentsSupport();
305305
export enum RNExperimentName {
306306
REACT_NATIVE_SPECIFIC_UI = 'react-native-specific-ui',
307307
JS_HEAP_PROFILER_ENABLE = 'js-heap-profiler-enable',
308-
ENABLE_PERFORMANCE_PANEL = 'enable-performance-panel',
309308
ENABLE_NETWORK_PANEL = 'enable-network-panel',
310309
}
311310

@@ -341,7 +340,6 @@ export const enum ExperimentName {
341340
JS_HEAP_PROFILER_ENABLE = RNExperimentName.JS_HEAP_PROFILER_ENABLE,
342341
REACT_NATIVE_SPECIFIC_UI = RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
343342
NOT_REACT_NATIVE_SPECIFIC_UI = '!' + RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
344-
ENABLE_PERFORMANCE_PANEL = RNExperimentName.ENABLE_PERFORMANCE_PANEL,
345343
ENABLE_NETWORK_PANEL = RNExperimentName.ENABLE_NETWORK_PANEL,
346344
}
347345

front_end/entrypoints/rn_fusebox/FuseboxExperimentsObserver.ts

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ import * as UI from '../../ui/legacy/legacy.js';
1313
import {FuseboxWindowTitleManager} from './FuseboxWindowTitleManager.js';
1414

1515
const UIStrings = {
16-
/**
17-
* @description Message for the "settings changed" banner shown when a reload is required for the Performance panel.
18-
*/
19-
reloadRequiredForPerformancePanelMessage:
20-
'[Profiling build first run] One or more settings have changed. Please reload to access the Performance panel.',
2116
/**
2217
* @description Message for the "settings changed" banner shown when a reload is required for the Network panel.
2318
*/
@@ -55,7 +50,6 @@ export class FuseboxFeatureObserver implements
5550
if (unstable_isProfilingBuild) {
5651
FuseboxWindowTitleManager.instance().setSuffix('[PROFILING]');
5752
this.#hideUnsupportedFeaturesForProfilingBuilds();
58-
this.#ensurePerformancePanelEnabled();
5953
}
6054

6155
if (unstable_networkInspectionEnabled) {
@@ -91,26 +85,6 @@ export class FuseboxFeatureObserver implements
9185
});
9286
}
9387

94-
#ensurePerformancePanelEnabled(): void {
95-
if (
96-
!Root.Runtime.experiments.isEnabled(
97-
Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
98-
)
99-
) {
100-
Root.Runtime.experiments.setEnabled(
101-
Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
102-
true,
103-
);
104-
105-
const inspectorView = UI.InspectorView?.InspectorView?.instance();
106-
if (inspectorView) {
107-
inspectorView.displayReloadRequiredWarning(
108-
i18nString(UIStrings.reloadRequiredForPerformancePanelMessage),
109-
);
110-
}
111-
}
112-
}
113-
11488
#ensureNetworkPanelEnabled(): void {
11589
if (Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.ENABLE_NETWORK_PANEL)) {
11690
return;

front_end/global_typings/react_native.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,5 @@ declare global {
1919
var reactNativeOpenInEditorButtonImage: string|undefined;
2020
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
2121
var FB_ONLY__reactNativeFeedbackLink: string|undefined;
22-
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
23-
var FB_ONLY__enablePerformance: unknown;
2422
}
2523
}

front_end/panels/timeline/timeline-meta.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ UI.ViewManager.registerViewExtension({
8888
title: i18nLazyString(UIStrings.performance),
8989
commandPrompt: i18nLazyString(UIStrings.showPerformance),
9090
order: 50,
91-
experiment: globalThis.FB_ONLY__enablePerformance === true ? undefined : Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
9291
async loadView() {
9392
const Timeline = await loadTimelineModule();
9493
return Timeline.TimelinePanel.TimelinePanel.instance();

0 commit comments

Comments
 (0)