Skip to content

chore: hide unsupported memory profiling options #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

chore: hide unsupported memory profiling options #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion front_end/panels/profiler/HeapProfilerPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import * as Host from '../../core/host/host.js';
import * as i18n from '../../core/i18n/i18n.js';
import * as Root from '../../core/root/root.js';
import type * as SDK from '../../core/sdk/sdk.js';
import * as UI from '../../ui/legacy/legacy.js';

Expand All @@ -24,8 +25,17 @@ let heapProfilerPanelInstance: HeapProfilerPanel;
export class HeapProfilerPanel extends ProfilesPanel implements UI.ContextMenu.Provider<SDK.RemoteObject.RemoteObject>,
UI.ActionRegistration.ActionDelegate {
constructor() {
const isReactNative = Root.Runtime.experiments.isEnabled(
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
);
const registry = instance;
const profileTypes = [
// [RN] Allocation sampling and Detached elements memory profiling options are not supported.
// We are hiding these options from the UI.
const profileTypes = isReactNative ? [
registry.heapSnapshotProfileType,
registry.trackingHeapSnapshotProfileType,
registry.samplingHeapProfileType,
] : [
registry.heapSnapshotProfileType,
registry.trackingHeapSnapshotProfileType,
registry.samplingHeapProfileType,
Expand Down
Loading