Skip to content

Conversation

vzaidman
Copy link

Summary

Following #188, allow frames with the format

    at anonymous (eval:12:2)

coming from Hermes when there's a TypeError or ReferenceError when executing bundles.

Test plan

Before:
Screenshot 2025-07-23 at 10 20 24

After:
Screenshot 2025-07-23 at 10 27 26

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@huntie
Copy link
Member

huntie commented Jul 23, 2025

@vzaidman Should the target branch for this PR be main?

@vzaidman
Copy link
Author

Yea, I'll change it once the previous branch is merged. Cheers!

@vzaidman vzaidman force-pushed the allow-skipping-x-frames-parsing branch from e9f2055 to 3b58e23 Compare July 23, 2025 13:38
@vzaidman vzaidman force-pushed the allow-eval-frames-parsing branch 2 times, most recently from 0f401ca to 41ad8d8 Compare July 23, 2025 13:50
hoxyq
hoxyq approved these changes Jul 23, 2025
@vzaidman vzaidman force-pushed the allow-skipping-x-frames-parsing branch from 3b58e23 to fb5038f Compare July 23, 2025 15:15
Base automatically changed from allow-skipping-x-frames-parsing to main July 23, 2025 15:37
@vzaidman vzaidman force-pushed the allow-eval-frames-parsing branch from 41ad8d8 to c1da2df Compare July 23, 2025 15:42
@vzaidman
Copy link
Author

@huntie notice-

Base automatically changed from allow-skipping-x-frames-parsing to main

once you merge the branch it changes to main automatically. I just needed to specify in my PR that it is 2/2.

@vzaidman vzaidman merged commit a7e4f59 into main Jul 23, 2025
5 checks passed
@vzaidman vzaidman deleted the allow-eval-frames-parsing branch July 23, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants