Skip to content

allow parsing frames with eval url #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

allow parsing frames with eval url #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions front_end/panels/console/ErrorStackParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ export type SpecialHermesStackTraceFrameTypes =
// for the frame so that a debugger could stitch together a
// hybrid cross-language call stack
'native' |
// e.g "(eval:1:2)"- Seem to be reported when there's a
// ReferenceError or TypeError during the initial bundle code execution.
// TODO: Understand exactly where these originate from and what further work
// should be done in regards to them
'eval' |
// e.g "(:3:4)"- Frames with empty url
// TODO: Seems to be happening due to a bug that needs to be investigated
// and produce an actual script URL instead
Expand All @@ -44,6 +49,10 @@ function getSpecialHermesFrameBasedOnURL(url: string): SpecialHermesStackTraceFr
return 'native';
}

if (url === 'eval') {
return 'eval';
}

if (url === '') {
return 'empty url';
}
Expand Down Expand Up @@ -89,7 +98,7 @@ export function parseSourcePositionsFromErrorStack(
if (!match) {
if (linkInfos.length && linkInfos[linkInfos.length - 1].isCallFrame) {
const specialHermesFrameType = getSpecialHermesFrameBasedOnLine(line);
if (specialHermesFrameType) {
if (specialHermesFrameType !== null) {
specialHermesFramesParsed.add(specialHermesFrameType);
if (!linkInfos[linkInfos.length - 1].link) {
// Combine builtin frames.
Expand Down Expand Up @@ -136,7 +145,7 @@ export function parseSourcePositionsFromErrorStack(
const linkCandidate = line.substring(left, right);
const splitResult = Common.ParsedURL.ParsedURL.splitLineAndColumn(linkCandidate);
const specialHermesFrameType = getSpecialHermesFrameBasedOnURL(splitResult.url);
if (specialHermesFrameType) {
if (specialHermesFrameType !== null) {
specialHermesFramesParsed.add(specialHermesFrameType);
}

Expand Down
Loading