refactor[DebuggingRegistry]: highlight nodes only on the lowest container for modern implementations#41818
Closed
hoxyq wants to merge 9 commits into
Closed
refactor[DebuggingRegistry]: highlight nodes only on the lowest container for modern implementations#41818hoxyq wants to merge 9 commits into
hoxyq wants to merge 9 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51713089 |
Base commit: af8c56a |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51713089 |
hoxyq
force-pushed
the
export-D51713089
branch
from
c57e6cd to
7f92a35
Compare
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods. For some methods actual implementation will be published in the next diffs. Differential Revision: https://internalfb.com/D51536787 fbshipit-source-id: 9870b4dd3ae50fae4646e19f2ec41e544846b664
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603860 fbshipit-source-id: 256eba6ed45ddd161a150cad682fb392587fecbe
…ents Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603861 fbshipit-source-id: 515e4b200dfa09ad1749622c6c708aa09a2a5477
…vTools Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51708053 fbshipit-source-id: bfbdcea300dd452d6691db5be88d5fe2af273277
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51708055 fbshipit-source-id: 709a99b5b1a5b949bae8998082ad85743d440524
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51708054 fbshipit-source-id: 0347797ebd685847ff8df6e3f91641753a72c280
Summary: Changelog: [Internal] TODO: add a link to github issue about brownfield app being broken in dev mode Differential Revision: https://internalfb.com/D50644900 fbshipit-source-id: 33f34f70fbd06915144d8c26eff676a186e18f54
Summary: Changelog: [Internal] Forking implementations for trace updates and element highlights from React DevTools: modern and legacy. Both implementations will later solve the same problem of highlighting the component only on a single AppContainer, but with different approaches: - Modern will be based on DOM Node APIs: `getBoundingClientRect` and `parentElement`. - Legacy will be based on `isChildInstance` from renderer and `measure`. All corresponding API call will be added in a separate diff later on top of these changes. Differential Revision: https://internalfb.com/D51713087 fbshipit-source-id: ad30ccc775c948c3e1d2bee00c51865cade778a2
…iner for modern implementations (react#41818) Summary: Pull Request resolved: react#41818 Changelog: [Internal] Use `parentElement` API to find lowest AppContainer ancestor, which will be responsible for highlighting an inspected element or rendering trace updates frames on the screen. Differential Revision: D51713089 fbshipit-source-id: 3d885cc315b1557449f3a88e64703b31f916abe3
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51713089 |
hoxyq
force-pushed
the
export-D51713089
branch
from
7f92a35 to
6e93419
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…t container for modern implementations (react#41818) Summary: Pull Request resolved: react#41818 Changelog: [Internal] Use `parentElement` API to find lowest AppContainer ancestor, which will be responsible for highlighting an inspected element or rendering trace updates frames on the screen. Differential Revision: D51713089 Reviewed By: sammy-SC fbshipit-source-id: 6a972a3f1565f0aeedf9ee691aef9cf7d88acf65
Contributor
|
This pull request has been merged in 5162b43. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Use
parentElementAPI to find lowest AppContainer ancestor, which will be responsible for highlighting an inspected element or rendering trace updates frames on the screen.Differential Revision: D51713089