Add position type to LayoutMetrics#41819
Closed
joevilches wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51412428 |
Base commit: 7d1a98c |
joevilches
force-pushed
the
export-D51412428
branch
from
75b431a to
bbc66a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51412428 |
joevilches
force-pushed
the
export-D51412428
branch
from
bbc66a3 to
45acd6b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51412428 |
Summary: This will be needed in order to access the position type while implementing offsetLeft/Top, which needs to know if a node is static or not to get the proper offset. This is simply making the position type available to be read from LayoutMetrics. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51412428
joevilches
force-pushed
the
export-D51412428
branch
from
45acd6b to
fadb921
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51412428 |
Contributor
|
This pull request has been merged in 3fb47c5. |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 20, 2023
Summary: I added position type in D51412428 (react#41819). I didn't notice this == override which makes it so position type in layout metrics will not be updated if it changes. Changelog: [Internal] Differential Revision: D52339890
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 20, 2023
Summary: I added position type in D51412428 (react#41819). I didn't notice this == override which makes it so position type in layout metrics will not be updated if it changes. Changelog: [Internal] Differential Revision: D52339890
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Summary: Pull Request resolved: #42020 I added position type in D51412428 (#41819). I didn't notice this == override which makes it so position type in layout metrics will not be updated if it changes. To use this cpp 20 feature we needed to change a few buck files which is also done here Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52339890 fbshipit-source-id: e77ee092477dbf786e4a72e6a33138ccbc450645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This will be needed in order to access the position type while implementing offsetLeft/Top, which needs to know if a node is static or not to get the proper offset. This is simply making the position type available to be read from LayoutMetrics.
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D51412428