Java CxxInspectorPackagerConnection#42018

Closed

motiz88 wants to merge 1 commit into

motiz88:export-D52231237

motiz88 commented Dec 20, 2023

Contributor

Summary:
Creates an JNI wrapper around the C++ version of InspectorPackagerConnection (introduced in D52134592), and uses it in React Native Android apps (behind an internal flag that is off by default).

In future work, the flag will be turned on by default, then deleted, and eventually the legacy InspectorPackagerConnection.java code will be deleted from React Native.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D52231237

facebook-github-bot added CLA Signed p: Facebook Partner labels

facebook-github-bot commented Dec 20, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

facebook-github-bot added the fb-exported label

facebook-github-bot commented Dec 20, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from c906cd7 to 9c4f8fc Compare

December 20, 2023 19:53

motiz88 force-pushed the export-D52231237 branch from 9c4f8fc to 40bb853 Compare

December 21, 2023 15:04

facebook-github-bot commented Dec 21, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from 40bb853 to fbca57f Compare

December 21, 2023 15:41

facebook-github-bot commented Dec 21, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from fbca57f to 4bf50d9 Compare

December 21, 2023 15:48

facebook-github-bot commented Dec 21, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from 4bf50d9 to 291d61e Compare

December 21, 2023 16:14

facebook-github-bot commented Dec 21, 2023

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

analysis-bot commented Dec 21, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,769,612	+127,174
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,161,477	+123,053
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: aa2d613
Branch: main

facebook-github-bot commented Jan 6, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from 291d61e to 553f7c2 Compare

January 6, 2024 01:53

facebook-github-bot commented Jan 6, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from 553f7c2 to b9bcdbf Compare

January 6, 2024 03:08

facebook-github-bot commented Jan 9, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from b9bcdbf to 7c200c3 Compare

January 9, 2024 13:55

facebook-github-bot commented Jan 9, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from 7c200c3 to a8e4beb Compare

January 9, 2024 16:19


          Java CxxInspectorPackagerConnection (react#42018)

dca8c4e

Summary:
Pull Request resolved: react#42018

Creates an JNI wrapper around the C++ version of `InspectorPackagerConnection` (introduced in D52134592), and uses it in React Native Android apps (behind an internal flag that is off by default).

In future work, the flag will be turned on by default, then deleted, and eventually the legacy `InspectorPackagerConnection.java` code will be deleted from React Native.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D52231237

fbshipit-source-id: d5d32aee39f9cb978f7208b1ad98218d00c35bd3

facebook-github-bot commented Jan 9, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D52231237

motiz88 force-pushed the export-D52231237 branch from a8e4beb to dca8c4e Compare

January 9, 2024 16:51

facebook-github-bot closed this in

a9a736f

facebook-github-bot added the Merged label

facebook-github-bot commented Jan 9, 2024

Contributor

This pull request has been merged in a9a736f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner