Skip to content

Use default inequality operator for LayoutMetrics#42189

Closed
joevilches wants to merge 1 commit into
react:mainfrom
joevilches:export-D52515802
Closed

Use default inequality operator for LayoutMetrics#42189
joevilches wants to merge 1 commit into
react:mainfrom
joevilches:export-D52515802

Conversation

@joevilches

Copy link
Copy Markdown
Contributor

Summary:
tsia, we had the equality op defaulted so might as well do this for inequality

Changelog: [Internal]

Differential Revision: D52515802

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52515802

@analysis-bot

analysis-bot commented Jan 8, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,642,025 +3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,037,996 -12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2e2f8a6
Branch: main

joevilches added a commit to joevilches/react-native that referenced this pull request Jan 9, 2024
)

Summary:

tsia, we had the equality op defaulted so might as well do this for inequality 

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D52515802
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52515802

Summary:

tsia, we had the equality op defaulted so might as well do this for inequality 

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D52515802
joevilches added a commit to joevilches/react-native that referenced this pull request Jan 9, 2024
)

Summary:

tsia, we had the equality op defaulted so might as well do this for inequality 

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D52515802
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52515802

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 9, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in de45105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants