Allow non-static LongLivedObjectCollections in TurboModuleBinding#42194
Allow non-static LongLivedObjectCollections in TurboModuleBinding#42194rozele wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
Base commit: a9a736f |
rozele
force-pushed
the
export-D52581170
branch
from
a607a1b to
7a76394
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
7a76394 to
69a7e21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
69a7e21 to
e91b114
Compare
rozele
force-pushed
the
export-D52581170
branch
from
e91b114 to
0102d44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
0102d44 to
5adfb88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
5adfb88 to
eef1279
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
eef1279 to
01ac7eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
01ac7eb to
f296e2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
f296e2c to
200780d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
200780d to
6e082b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
…act#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
6e082b7 to
11279ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
|
This pull request has been merged in f7f9250. |
3 participants
Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files here for the reasons already mentioned) to manage per instance LongLivedObjectCollections.
Differential Revision: D52581170