C++ InspectorPackagerConnection: Indicate new implementation in /json response#42200
Closed
motiz88 wants to merge 1 commit into
Closed
C++ InspectorPackagerConnection: Indicate new implementation in /json response#42200motiz88 wants to merge 1 commit into
/json response#42200motiz88 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52629415 |
motiz88
force-pushed
the
export-D52629415
branch
from
2c10b91 to
c2c5150
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52629415 |
motiz88
force-pushed
the
export-D52629415
branch
from
c2c5150 to
35c1711
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52629415 |
Base commit: 9525074 |
…n` response (react#42200) Summary: Changelog: [Internal] Quick hack to make it easy to determine whether a given build of React Native is using the C++ implementation of InspectorPackagerConnection or the legacy platform-specific implementation. For now, we just append this information to the `title` field. Ultimately, rather than polluting the title, this should be an inert capability flag that gets reported via `inspector-proxy`. I'm not doing that yet since we have work in the pipeline to set up a proper capability flag system soon. Reviewed By: huntie Differential Revision: D52629415
motiz88
force-pushed
the
export-D52629415
branch
from
35c1711 to
e241bad
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52629415 |
|
This pull request was successfully merged by @motiz88 in 4d22d02. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D52629415