'[skip ci] [Venice][Android] Refactor: ReactInstance: Inline getUIManagerConstants()#42215
Closed
RSNara wants to merge 2 commits into
Closed
'[skip ci] [Venice][Android] Refactor: ReactInstance: Inline getUIManagerConstants()#42215RSNara wants to merge 2 commits into
RSNara wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52399002 |
…section (react#42205) Summary: This diff should not change any behaviour. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52399004
Summary: This diff should not change any behaviour. **Why:** This logic is only used once from the UIConstantsProviderManager. So, let's just inline it. Inlining this method will make ReactInstance.java have fewer private methods, which'll make ReactInstance.java easier to read. **Concern:** Inlining this method into ReactInstance's constructor will make the constructor too hard to read. - I think it'll be fine: we will simplify this method significantly in D52399003. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52399002
RSNara
force-pushed
the
export-D52399002
branch
from
7c861bf to
b5e4f89
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…act#42215) Summary: This diff should not change any behaviour. **Why:** This logic is only used once from the UIConstantsProviderManager. So, let's just inline it. Inlining this method will make ReactInstance.java have fewer private methods, which'll make ReactInstance.java easier to read. **Concern:** Inlining this method into ReactInstance's constructor will make the constructor too hard to read. - I think it'll be fine: we will simplify this method significantly in D52399003. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52399002
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…act#42215) Summary: This diff should not change any behaviour. **Why:** This logic is only used once from the UIConstantsProviderManager. So, let's just inline it. Inlining this method will make ReactInstance.java have fewer private methods, which'll make ReactInstance.java easier to read. **Concern:** Inlining this method into ReactInstance's constructor will make the constructor too hard to read. - I think it'll be fine: we will simplify this method significantly in D52399003. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52399002
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52399002 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…act#42215) Summary: This diff should not change any behaviour. **Why:** This logic is only used once from the UIConstantsProviderManager. So, let's just inline it. Inlining this method will make ReactInstance.java have fewer private methods, which'll make ReactInstance.java easier to read. **Concern:** Inlining this method into ReactInstance's constructor will make the constructor too hard to read. - I think it'll be fine: we will simplify this method significantly in D52399003. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52399002
Base commit: 9155e2d |
Contributor
|
This pull request has been merged in a31a456. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff should not change any behaviour.
Why: This logic is only used once from the UIConstantsProviderManager. So, let'''s just inline it. Inlining this method will make ReactInstance.java have fewer private methods, which'''ll make ReactInstance.java easier to read.
Concern: Inlining this method into ReactInstance'''s constructor will make the constructor too hard to read.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D52399002