Re-add RCTHermesInstance constructor for compatibility
#46453
Closed
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
33 tasks
facebook-github-bot
added
the
Shared with Meta
cortinico
approved these changes
Sep 12, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in aec6666. |
|
This pull request was successfully merged by @tido64 in aec6666 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: #46314 introduced a breaking change, making it hard to maintain backwards compatibility elsewhere. This change re-introduces the constructor that takes two arguments. ## Changelog: [IOS] [FIXED] - Unbreak `RCTHermesInstance` constructor breaking change Pull Request resolved: #46453 Test Plan: n/a Reviewed By: javache Differential Revision: D62574496 Pulled By: cortinico fbshipit-source-id: dcd15bf9694f4b14e37d61d7209193b3e448cd6b
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#46314 introduced a breaking change, making it hard to maintain backwards compatibility elsewhere. This change re-introduces the constructor that takes two arguments.
Changelog:
[IOS] [FIXED] - Unbreak
RCTHermesInstanceconstructor breaking changeTest Plan:
n/a