Skip to content

fix: fix @react-native-community/cli not being found in monorepos #47304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+16 −2
Closed

fix: fix @react-native-community/cli not being found in monorepos #47304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8826dc0
fix: fix `@react-native-community/cli` not being found in pnpm setups
tido64 Oct 30, 2024
0c4b65d
comment on cwd usage
tido64 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/react-native/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@ const deprecated = () => {
);
};

function findCommunityCli(startDir = process.cwd()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is process.cwd() in this context? It seems fragile to assume that's where the dependency is declared.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's where the react-native command is being executed from, which should be project root. I am not familiar with use cases where it's being executed elsewhere.

// In monorepos, we cannot make any assumptions on where
// `@react-native-community/cli` gets installed. The safest way to find it
// (barring adding an optional peer dependency) is to start from the project
// root.
//
// Note that we're assuming that the current working directory is the project
// root. This is also what `@react-native-community/cli` assumes (see
// https://github.com/react-native-community/cli/blob/14.x/packages/cli-tools/src/findProjectRoot.ts).
const options = { paths: [startDir] };
const rncli = require.resolve('@react-native-community/cli', options);
return require(rncli);
}

function isMissingCliDependency(error) {
return (
error.code === 'MODULE_NOT_FOUND' &&
Expand Down Expand Up @@ -217,7 +231,7 @@ async function main() {
}

try {
return require('@react-native-community/cli').run(name);
return findCommunityCli().run(name);
} catch (e) {
if (isMissingCliDependency(e)) {
warnWithExplicitDependency();
Expand All @@ -231,7 +245,7 @@ if (require.main === module) {
main();
} else {
try {
cli = require('@react-native-community/cli');
cli = findCommunityCli();
} catch (e) {
// We silence @react-native-community/cli missing as it is no
// longer a dependency
Expand Down
Loading