Skip to content

Commit 4123d72

Browse files
author
Brian Vaughn
authored
Revert "Revert: Enable new passive effect behavior for FB builds (#18467)" (#18468)
This reverts commit 3966081.
1 parent 8815e4c commit 4123d72

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ export const enableTrustedTypesIntegration = false;
3737
export const disableTextareaChildren = false;
3838
export const disableModulePatternComponents = false;
3939
export const warnUnstableRenderSubtreeIntoContainer = false;
40-
export const deferPassiveEffectCleanupDuringUnmount = false;
41-
export const runAllPassiveEffectDestroysBeforeCreates = false;
40+
export const deferPassiveEffectCleanupDuringUnmount = true;
41+
export const runAllPassiveEffectDestroysBeforeCreates = true;
4242
export const enableModernEventSystem = false;
4343
export const warnAboutSpreadingKeyToJSX = false;
4444
export const enableLegacyFBSupport = false;

packages/shared/forks/ReactFeatureFlags.testing.www.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ export const enableTrustedTypesIntegration = false;
3737
export const disableTextareaChildren = __EXPERIMENTAL__;
3838
export const disableModulePatternComponents = true;
3939
export const warnUnstableRenderSubtreeIntoContainer = false;
40-
export const deferPassiveEffectCleanupDuringUnmount = false;
41-
export const runAllPassiveEffectDestroysBeforeCreates = false;
40+
export const deferPassiveEffectCleanupDuringUnmount = true;
41+
export const runAllPassiveEffectDestroysBeforeCreates = true;
4242
export const enableModernEventSystem = false;
4343
export const warnAboutSpreadingKeyToJSX = false;
4444
export const enableLegacyFBSupport = !__EXPERIMENTAL__;

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
// Use __VARIANT__ to simulate a GK. The tests will be run twice: once
1414
// with the __VARIANT__ set to `true`, and once set to `false`.
1515

16-
export const deferPassiveEffectCleanupDuringUnmount = __VARIANT__;
17-
export const runAllPassiveEffectDestroysBeforeCreates = __VARIANT__;
1816
export const warnAboutSpreadingKeyToJSX = __VARIANT__;
1917
export const disableModulePatternComponents = __VARIANT__;
2018
export const disableInputAttributeSyncing = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@ const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags');
1616

1717
export const {
1818
debugRenderPhaseSideEffectsForStrictMode,
19-
deferPassiveEffectCleanupDuringUnmount,
2019
disableModulePatternComponents,
2120
disableInputAttributeSyncing,
2221
enableTrustedTypesIntegration,
23-
runAllPassiveEffectDestroysBeforeCreates,
2422
disableSchedulerTimeoutBasedOnReactExpirationTime,
2523
warnAboutSpreadingKeyToJSX,
2624
replayFailedUnitOfWorkWithInvokeGuardedCallback,
@@ -79,6 +77,9 @@ export const throwEarlyForMysteriousError = false;
7977
// to the correct value.
8078
export const enableNewReconciler = __VARIANT__;
8179

80+
export const deferPassiveEffectCleanupDuringUnmount = true;
81+
export const runAllPassiveEffectDestroysBeforeCreates = true;
82+
8283
// Flow magic to verify the exports of this file match the original version.
8384
// eslint-disable-next-line no-unused-vars
8485
type Check<_X, Y: _X, X: Y = _X> = null;

0 commit comments

Comments
 (0)