Skip to content

Commit b779dd5

Browse files
authored
Stop syncing ReactTypes to RN (#18366)
This is a really old one and all callers have since been codemodded away anyway because of problems. This file is not really as rigorously maintained as the official Flow types but has a few more specifics. However, the inconsistency causes problems when you try to pass files typed using the built-in Flow typing for React and mix it with these. We just happen to get away with it because we compile out the types. If we didn't we would hit those problems by even using these in our renderers.
1 parent c5d2fc7 commit b779dd5

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

scripts/rollup/packaging.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,9 @@ async function copyWWWShims() {
8787
}
8888

8989
async function copyRNShims() {
90-
const reactTypesBuildTarget = 'build/react-native/shims/ReactTypes.js';
9190
await Promise.all([
9291
// React Native
9392
asyncCopyTo(`${__dirname}/shims/react-native`, 'build/react-native/shims'),
94-
asyncCopyTo(require.resolve('shared/ReactTypes.js'), reactTypesBuildTarget),
9593
asyncCopyTo(
9694
require.resolve('react-native-renderer/src/ReactNativeTypes.js'),
9795
'build/react-native/shims/ReactNativeTypes.js'

0 commit comments

Comments
 (0)