Skip to content

Fix the data-height of Step 5 CodePen embed#10083

Merged
nhunzaker merged 1 commit intofacebook:masterfrom
guiruiz:patch-1
Jul 4, 2017
Merged

Fix the data-height of Step 5 CodePen embed#10083
nhunzaker merged 1 commit intofacebook:masterfrom
guiruiz:patch-1

Conversation

@guiruiz
Copy link
Copy Markdown
Contributor

@guiruiz guiruiz commented Jun 30, 2017

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nhunzaker
Copy link
Copy Markdown
Contributor

Just to illustrate, this fixes the height of the final example:
https://facebook.github.io/react/docs/thinking-in-react

From:

screen shot 2017-07-03 at 9 03 53 pm

To:

screen shot 2017-07-03 at 9 04 26 pm

This is good by me.

@nhunzaker nhunzaker merged commit 83f5637 into facebook:master Jul 4, 2017
@nhunzaker
Copy link
Copy Markdown
Contributor

Thanks, @guiruiz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants