Skip to content

Delete react-dom-factories package#10279

Merged
gaearon merged 1 commit intofacebook:masterfrom
gaearon:no-dom-factories
Jul 26, 2017
Merged

Delete react-dom-factories package#10279
gaearon merged 1 commit intofacebook:masterfrom
gaearon:no-dom-factories

Conversation

@gaearon
Copy link
Copy Markdown
Collaborator

@gaearon gaearon commented Jul 26, 2017

This package is already published at 1.0.0.
Unlike the version in src, the published version is already standalone and inlined.

It seems to me that we won’t be changing this package further. And even if we will, we’ll do it from 15-stable. So I’m deleting this.

@gaearon
Copy link
Copy Markdown
Collaborator Author

gaearon commented Jul 26, 2017

Seems safe enough, I’ll just merge.

@gaearon gaearon merged commit 77e1129 into facebook:master Jul 26, 2017
@mjomble
Copy link
Copy Markdown
Contributor

mjomble commented Jul 27, 2017

Seems like this broke the link in the deprecation warning - https://fb.me/react-dom-factories

@gaearon
Copy link
Copy Markdown
Collaborator Author

gaearon commented Jul 27, 2017

Hmm. That's good because it was pointing to the wrong place. Let me update the link. Thanks for noticing!

@gaearon
Copy link
Copy Markdown
Collaborator Author

gaearon commented Jul 27, 2017

Fixed now.

@gaearon gaearon deleted the no-dom-factories branch July 27, 2017 13:36
@nhunzaker
Copy link
Copy Markdown
Contributor

For great justice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants