Added naive scheduleDeferredCallback implementation for RN#11362
Merged
bvaughn merged 2 commits intofacebook:masterfrom Oct 25, 2017
Merged
Added naive scheduleDeferredCallback implementation for RN#11362bvaughn merged 2 commits intofacebook:masterfrom
bvaughn merged 2 commits intofacebook:masterfrom
Conversation
acdlite
approved these changes
Oct 25, 2017
sebmarkbage
reviewed
Oct 25, 2017
| @@ -0,0 +1,65 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
We should probably call this something other than "FrameScheduling" since the plan is no longer to attempt to line up with Frames per se.
Contributor
Author
There was a problem hiding this comment.
I didn't think too hard about the name since we plan to change it soon anyway. I'll rename it when we do the real implementation.
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
…11362) * Added naive scheduleDeferredCallback implementation for RN * Fixed ReactNative shim's expected @provideModule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unblocks initial async testing.
Based on initial testing, I'll also be submitting a related PR for React Native's
createAnimatedComponentto make it account for potential async behavior.Also fixed up a small thing I noticed while syncing and testing- rename RN shim's
'ReactNativeFiber-*exports toReactNativeRenderer-*. This broke after the recent project cleanup/reorg.