Re-enable UMD build for TestUtils#11599
Merged
nhunzaker merged 1 commit intofacebook:masterfrom Nov 20, 2017
emmadavieswilcox:testutils-umd-build
Merged
Re-enable UMD build for TestUtils#11599nhunzaker merged 1 commit intofacebook:masterfrom emmadavieswilcox:testutils-umd-build
nhunzaker merged 1 commit intofacebook:masterfrom
emmadavieswilcox:testutils-umd-build
Conversation
clemmy
approved these changes
Nov 20, 2017
nhunzaker
approved these changes
Nov 20, 2017
pulluru
approved these changes
Nov 20, 2017
Collaborator
|
Have you verified they work? |
Contributor
Author
|
I have, our test suite works again now and all our tests pass. Thanks for the swift responding today, been a huge help! |
Collaborator
|
Awesome, thanks. |
Contributor
|
@gaearon sorry, haha. I should have said something to confirm this. I pulled this into the test fixtures and was able to manipulate React inputs:
|
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11111.