Add test to ensure checked inputs don't accidentally get value="on"#12000
Merged
gaearon merged 1 commit intofacebook:masterfrom Jan 9, 2018
Merged
Conversation
In absence of a value, radio and checkboxes report a value of "on". Between 16 and 16.2, we assigned a node's value to it's current value in order to "dettach" it from defaultValue. This had the unfortunate side-effect of assigning value="on" to radio and checkboxes Related issues: facebook#11998
ManasJayanth
pushed a commit
to ManasJayanth/react
that referenced
this pull request
Jan 12, 2018
…acebook#12000) In absence of a value, radio and checkboxes report a value of "on". Between 16 and 16.2, we assigned a node's value to it's current value in order to "dettach" it from defaultValue. This had the unfortunate side-effect of assigning value="on" to radio and checkboxes Related issues: facebook#11998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In absence of a value, radio and checkboxes report a value of "on". Between 16 and 16.2, we assigned a node's value to it's current value in order to "deattach" it from defaultValue. This had the unfortunate side-effect of assigning value="on" to radio and checkboxes
Related issues:
#11998