Conversation
acdlite
force-pushed
the
fixnestedupdatebug
branch
from
330df69 to
0244cad
Compare
A recent change to the scheduler caused a regression when scheduling many updates within a single batch. Added a test case that would have caught this.
acdlite
force-pushed
the
fixnestedupdatebug
branch
from
0244cad to
05cba71
Compare
|
Was just coming to report this issue -- the issue it created for me was failures in unrelated enzyme tests when (really bad) test failures occurred. Thanks for the fixes, looking forward to the release! |
|
I would like to raise / explore one further issue though. The existence of this issue suggests that ReactDOM is somewhat stateful where at least in error cases, it has not returned to its initial state. This is minimally problematic for tests in my situation, but I could imagine issues in SPAs where they might want to attempt to recover from a catastrophic failure. Is there some kind of full reset? Or are these stateful moments accidental? Worth an issue / more investigation? |
|
This is a fix for an issue that only existed on master and not in any stable release. |
|
@gaearon The PR description of scheduler batching, yes was not released, but the Fixes other issues for me. In the past, anything which hit this error could never recover. |
|
Thanks for explaining. Let's continue in #13188. |
4 participants
A recent change to the scheduler caused a regression when scheduling many updates within a single batch. Added a test case that would have caught this.