Added SSR/hydration tests for modes, forwardRef, and Profiler#13195
Merged
bvaughn merged 3 commits intofacebook:masterfrom Jul 12, 2018
Merged
Added SSR/hydration tests for modes, forwardRef, and Profiler#13195bvaughn merged 3 commits intofacebook:masterfrom
bvaughn merged 3 commits intofacebook:masterfrom
Conversation
bvaughn
changed the title
bvaughn
force-pushed
the
ssr-hydration-special-component-tests
branch
from
fb16396 to
163365d
Compare
bvaughn
force-pushed
the
ssr-hydration-special-component-tests
branch
from
163365d to
ef480db
Compare
gaearon
reviewed
Jul 11, 2018
| @@ -0,0 +1,56 @@ | |||
| /** | |||
Collaborator
There was a problem hiding this comment.
Can we combine these two files into IntegrationSpecialTypes or something? We don't expect to add many more tests to it, and each test file has some overhead.
gaearon
approved these changes
Jul 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't seem to have great coverage for these component types.