fix: do not reconcile children that are iterable functions#13416
Merged
gaearon merged 4 commits intofacebook:masterfrom Aug 16, 2018
raunofreiberg:ignore-iterable-functions
Merged
fix: do not reconcile children that are iterable functions#13416gaearon merged 4 commits intofacebook:masterfrom raunofreiberg:ignore-iterable-functions
gaearon merged 4 commits intofacebook:masterfrom
raunofreiberg:ignore-iterable-functions
Conversation
gaearon
reviewed
Aug 16, 2018
packages/shared/ReactSymbols.js
Outdated
| if ( | ||
| maybeIterable === null || | ||
| typeof maybeIterable === 'undefined' || | ||
| typeof maybeIterable === 'function' |
Collaborator
There was a problem hiding this comment.
Maybe just typeof maybeIterable !== 'object'?
gaearon
reviewed
Aug 16, 2018
packages/shared/ReactSymbols.js
Outdated
| if (maybeIterable === null || typeof maybeIterable === 'undefined') { | ||
| if ( | ||
| maybeIterable === null || | ||
| typeof maybeIterable === 'undefined' || |
Collaborator
There was a problem hiding this comment.
You don't need this check now.
Collaborator
|
Looks good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11396.
Does this seem reasonable? Should we also add a warning?