Skip to content

Remove unreachable code#13762

Merged
acdlite merged 1 commit intofacebook:masterfrom
NE-SmallTown:rm-ur
Oct 4, 2018
Merged

Remove unreachable code#13762
acdlite merged 1 commit intofacebook:masterfrom
NE-SmallTown:rm-ur

Conversation

@NE-SmallTown
Copy link
Copy Markdown
Contributor

Because in nextUnitOfWork = completeWork(...), completeWork(...) will always return null, so the if (next !== null) { ... } branch is unreachable. So we can just remove it.

@sizebot
Copy link
Copy Markdown

sizebot commented Oct 3, 2018

ReactDOM: size: -0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 3c60f32...0395010

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.0% 658.84 KB 658.45 KB 153.9 KB 153.88 KB UMD_DEV
react-dom.production.min.js -0.0% 0.0% 93.3 KB 93.28 KB 30.35 KB 30.35 KB UMD_PROD
react-dom.development.js -0.1% -0.0% 654.17 KB 653.79 KB 152.52 KB 152.5 KB NODE_DEV
react-dom.production.min.js -0.0% 🔺+0.1% 93.29 KB 93.27 KB 29.92 KB 29.96 KB NODE_PROD
ReactDOM-dev.js -0.1% -0.0% 671.44 KB 671.06 KB 153.24 KB 153.2 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 287.27 KB 287.33 KB 52.79 KB 52.77 KB FB_WWW_PROD
react-dom.profiling.min.js -0.0% -0.0% 96.29 KB 96.26 KB 30.59 KB 30.58 KB NODE_PROFILING
ReactDOM-profiling.js -0.1% -0.1% 294.17 KB 294.02 KB 54.26 KB 54.2 KB FB_WWW_PROFILING
react-dom.profiling.min.js -0.0% -0.0% 96.22 KB 96.19 KB 31.04 KB 31.02 KB UMD_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.0% 448.78 KB 448.4 KB 100.32 KB 100.3 KB UMD_DEV
react-art.production.min.js -0.0% -0.1% 85.73 KB 85.71 KB 26.22 KB 26.21 KB UMD_PROD
react-art.development.js -0.1% -0.0% 380.56 KB 380.17 KB 83.15 KB 83.13 KB NODE_DEV
react-art.production.min.js -0.0% -0.1% 50.7 KB 50.68 KB 15.49 KB 15.48 KB NODE_PROD
ReactART-dev.js -0.1% -0.0% 384.59 KB 384.2 KB 81.68 KB 81.64 KB FB_WWW_DEV
ReactART-prod.js -0.1% -0.0% 163.07 KB 162.96 KB 27.4 KB 27.39 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.1% -0.0% 392.66 KB 392.28 KB 85.72 KB 85.7 KB UMD_DEV
react-test-renderer.production.min.js -0.0% 0.0% 51.92 KB 51.9 KB 15.77 KB 15.77 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.0% 388.23 KB 387.84 KB 84.59 KB 84.57 KB NODE_DEV
react-test-renderer.production.min.js -0.0% 0.0% 51.64 KB 51.62 KB 15.58 KB 15.58 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.0% 392.35 KB 391.97 KB 83.39 KB 83.35 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.1% -0.0% 376.39 KB 376 KB 81.24 KB 81.21 KB NODE_DEV
react-reconciler.production.min.js -0.0% -0.1% 50.39 KB 50.37 KB 15.04 KB 15.02 KB NODE_PROD
react-reconciler-persistent.development.js -0.1% -0.0% 374.92 KB 374.53 KB 80.64 KB 80.61 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.0% -0.1% 50.4 KB 50.38 KB 15.04 KB 15.03 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.1% -0.0% 508.46 KB 508.07 KB 112.18 KB 112.15 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% -0.0% 218.17 KB 218.05 KB 37.81 KB 37.79 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.1% -0.0% 508.15 KB 507.76 KB 112.1 KB 112.07 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.1% -0.0% 208.45 KB 208.33 KB 36.28 KB 36.27 KB RN_OSS_PROD
ReactFabric-dev.js -0.1% -0.0% 498.6 KB 498.21 KB 109.75 KB 109.71 KB RN_FB_DEV
ReactFabric-prod.js -0.1% -0.0% 200.87 KB 200.77 KB 34.8 KB 34.8 KB RN_FB_PROD
ReactFabric-dev.js -0.1% -0.0% 498.63 KB 498.25 KB 109.76 KB 109.73 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% -0.0% 200.9 KB 200.8 KB 34.82 KB 34.81 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.2% -0.0% 216.04 KB 215.72 KB 37.72 KB 37.71 KB RN_OSS_PROFILING
ReactFabric-profiling.js -0.2% -0.1% 207.95 KB 207.58 KB 36.27 KB 36.24 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js -0.1% -0.0% 224.21 KB 223.88 KB 39.15 KB 39.14 KB RN_FB_PROFILING
ReactFabric-profiling.js -0.2% -0.1% 207.91 KB 207.54 KB 36.25 KB 36.22 KB RN_FB_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@acdlite acdlite merged commit 5c783ee into facebook:master Oct 4, 2018
acdlite pushed a commit to plievone/react that referenced this pull request Oct 5, 2018
linjiajian999 pushed a commit to linjiajian999/react that referenced this pull request Oct 22, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants